Skip to content

chore: Expanding lll coverage to dag-graph - #5869

Merged
yhakbar merged 1 commit into
mainfrom
chore/expanding-lll-coverage-to-dag-graph
May 7, 2026
Merged

chore: Expanding lll coverage to dag-graph#5869
yhakbar merged 1 commit into
mainfrom
chore/expanding-lll-coverage-to-dag-graph

Conversation

@yhakbar

@yhakbar yhakbar commented Apr 10, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Description

Addressed lll findings in dag-graph.

TODOs

Read the Gruntwork contribution guidelines.

  • I authored this code entirely myself
  • I am submitting code based on open source software (e.g. MIT, MPL-2.0, Apache)
  • I am adding or upgrading a dependency or adapted code and confirm it has a compatible open source license
  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated lll linter coverage to include dag-graph.

Summary by CodeRabbit

  • Style

    • Reformatted command documentation and test fixtures for improved readability.

  • Chores

    • Updated linter configuration to refine exclusion rules.

@vercel

vercel Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
terragrunt-docs Ready Ready Preview, Comment May 7, 2026 6:45pm

Request Review

@coderabbitai

coderabbitai Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 813d724e-80bb-4bef-b757-1dc6426bbefe

📥 Commits

Reviewing files that changed from the base of the PR and between a38c304 and 7c61950.

📒 Files selected for processing (3)
  • .golangci.yml
  • internal/cli/commands/dag/graph/cli.go
  • internal/cli/commands/dag/graph/cli_test.go
📝 Walkthrough

Walkthrough

Linter configuration updated to exclude additional internal paths. CLI command Usage string and test fixture list reformatted across multiple lines for improved readability, with no functional changes.

Changes

Linter Configuration and CLI Formatting

Layer / File(s) Summary
Linter Configuration
.golangci.yml		 The lll linter exclusion block adds a path-except regex pattern to exclude additional internal directory paths from line-length linting.
CLI Command and Test Formatting
internal/cli/commands/dag/graph/cli.go, internal/cli/commands/dag/graph/cli_test.go		 Command Usage string reformatted into multiple concatenated lines; BenchmarkRunGraphDependencies fixture list converted to multi-line struct literal format. Both changes are cosmetic and preserve all content.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • gruntwork-io/terragrunt#5854: Both PRs modify the same .golangci.yml linter configuration file, specifically the lll path-except exclusion pattern.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description addresses the core purpose but omits several required template sections including issue reference and several TODO items. Add the issue reference (Fixes #000) and include all required TODO checkboxes from the template, even if marked as not applicable.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: expanding the lll linter coverage to include dag-graph directories.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/expanding-lll-coverage-to-dag-graph

Comment @coderabbitai help to get the list of available commands and usage tips.

@yhakbar
yhakbar force-pushed the chore/expanding-lll-coverage-to-format-options branch from f89a99a to 6285f7c Compare April 29, 2026 19:34
@yhakbar
yhakbar force-pushed the chore/expanding-lll-coverage-to-dag-graph branch from b710861 to bad1a94 Compare April 29, 2026 19:34
@yhakbar
yhakbar marked this pull request as ready for review April 29, 2026 20:16
@yhakbar
yhakbar requested a review from denis256 as a code owner April 29, 2026 20:16
denis256
denis256 previously approved these changes May 7, 2026
View reviewed changes
Base automatically changed from chore/expanding-lll-coverage-to-format-options to main May 7, 2026 18:43
@yhakbar
yhakbar dismissed denis256’s stale review May 7, 2026 18:43

The base branch was changed.

@yhakbar
yhakbar force-pushed the chore/expanding-lll-coverage-to-dag-graph branch from bad1a94 to 7c61950 Compare May 7, 2026 18:43
@yhakbar
yhakbar merged commit f57ce70 into main May 7, 2026
17 of 18 checks passed
@yhakbar
yhakbar deleted the chore/expanding-lll-coverage-to-dag-graph branch May 7, 2026 18:53
Rahul-Kumar-prog pushed a commit to Rahul-Kumar-prog/terragrunt that referenced this pull request May 10, 2026
@yhakbar @Rahul-Kumar-prog
chore: Expanding lll coverage to dag-graph (gruntwork-io#5869)
445e7b3
@BrewTestBot BrewTestBot mentioned this pull request May 18, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denis256 denis256 denis256 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yhakbar @denis256